aws-node-termination-handler icon indicating copy to clipboard operation
aws-node-termination-handler copied to clipboard

helm: add envFrom templating option

Open cesarmira opened this issue 2 years ago • 1 comments

Describe the feature I would like to be able to configure the DaemonSet envFrom values from the values.yaml

Is the feature request related to a problem? No, as right now we can't configure it at all.

Describe alternatives you've considered At the moment, we are rendering the chart, updating the manifest and applying it manually. We believe it would be nice to be able to do it everything from the chart.

cesarmira avatar Jul 25 '22 02:07 cesarmira

Thanks for the suggestion! We'd be happy to accept a pull request with a fix for this issue.

Along with that, we'll help write an end-to-end test that verifies that the environment variables successfully appear in the pod after launch.

snay2 avatar Jul 27 '22 21:07 snay2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

github-actions[bot] avatar Aug 27 '22 17:08 github-actions[bot]

This issue was closed because it has become stale with no activity.

github-actions[bot] avatar Sep 01 '22 17:09 github-actions[bot]