aws-nitro-enclaves-cli
aws-nitro-enclaves-cli copied to clipboard
enclave_build: fix argument parsing and image generation
Description of changes:
- fixed inconsistencies in argument names that make it impossible to generate a signed image
- fixed potential image corruption if the output image already exists by truncating it before writing to it
- bump version to 0.2.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Checked the logs:
Makefile:221: recipe for target 'nitro-format' failed
Make sure to run cargo-fmt --all before commiting.
Checked the logs:
Makefile:221: recipe for target 'nitro-format' failedMake sure to runcargo-fmt --allbefore commiting.
done in https://github.com/aws/aws-nitro-enclaves-cli/pull/424/commits/dc6467971e9a9315a0ec64986b67be723567f741
Currently failing on license check make nitro-about. Opened a PR to update our license file. After we merge it, you should rebase.
Can you describe a bit more the issue that this patch is fixing? It seems to make the commandline arguments inconsistent, since they follow snake_case rather than kebab-case in enclave_build crate. I think they would all need to be updated to look the same.
Can you describe a bit more the issue that this patch is fixing? It seems to make the commandline arguments inconsistent, since they follow
snake_caserather thankebab-caseinenclave_buildcrate. I think they would all need to be updated to look the same.
The issue here is that it is not possible to create a signed image with enclave_build because the private key parameter is not parsed at all (instead the code reuses private_certificate which is imho a bug). I used private-key and not private_key because that's how the command line option is defined as the beginning of main.rs.