aws-nitro-enclaves-cli icon indicating copy to clipboard operation
aws-nitro-enclaves-cli copied to clipboard

Enclaves failing to start. `--attach_console` argument should be optional

Open jakekgrog opened this issue 3 years ago • 2 comments
trafficstars

The --attach_console flag was added in the latest release but has broken our builds as it wasn't optional https://github.com/aws/aws-nitro-enclaves-cli/blob/cdfa323f69a0cfff2204a25363c7334777c133d7/src/common/commands_parser.rs#L32

jakekgrog avatar Apr 04 '22 15:04 jakekgrog

Hi @jakekgrog, can you describe the issue in more detail? I ran a few tests and the enclaves seem to start just fine without --attach-console flag in either debug or production mode on release 1.2.0.

petreeftime avatar Apr 05 '22 07:04 petreeftime

There is no need for Optional there, as this doesn't reflect in either the way the CLI interprets the flags or the way that flag is used later on.

petreeftime avatar Apr 05 '22 07:04 petreeftime

Released in 1.2.1

alcioa avatar Nov 18 '22 18:11 alcioa