aws-lambda-dotnet icon indicating copy to clipboard operation
aws-lambda-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon aws

Support Cognito Pre Token Generation Event

Open GuzzoLM opened this issue 4 years ago • 3 comments

Issue #732

Description of changes: Add class for Cognito Pre Token Generation Lambda Trigger Parameters

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

GuzzoLM avatar Sep 17 '20 15:09 GuzzoLM

This PR would be covered by / conflict with #1051

jon-armen avatar Feb 09 '22 17:02 jon-armen

@GuzzoLM Thanks for your contribution. Is it fine to close this PR as duplicate of https://github.com/aws/aws-lambda-dotnet/pull/1051?

ashishdhingra avatar Feb 24 '22 20:02 ashishdhingra

@GuzzoLM Thanks for your contribution. Is it fine to close this PR as duplicate of #1051?

@ashishdhingra , do you have any updates when #1051 may be merged and released?

jon-armen avatar Feb 24 '22 21:02 jon-armen

Please review and merge this or 1051 soon. The contract in the Nuget package Amazon.Lambda.CognitoEvents is not valid any longer and causes an exception. Can you please remove this package from Nuget?

michaelakin avatar Oct 04 '22 14:10 michaelakin

Please review and merge this or 1051 soon. The contract in the Nuget package Amazon.Lambda.CognitoEvents is not valid any longer and causes an exception. Can you please remove this package from Nuget?

The PR https://github.com/aws/aws-lambda-dotnet/pull/1051 needs to have integration testing done to rule out any post-release issues.

ashishdhingra avatar Oct 04 '22 22:10 ashishdhingra

I ended up merging and releasing PR #1051 instead of this PR which also implemented this feature along with many other Cognito event types. That PR has been released as part of version 2.1.0 of Amazon.Lambda.CognitoEvents.

normj avatar Feb 13 '23 07:02 normj