aws-lambda-dotnet icon indicating copy to clipboard operation
aws-lambda-dotnet copied to clipboard
verified publisher icon aws

Register encoding options when adding the service to the service collection

Open hugohlln opened this issue 2 years ago • 3 comments

Issue:: #1574

Description of changes: Can now register content type for transformation by passing options to the HostingOptions object

hugohlln avatar Aug 31 '23 09:08 hugohlln

Good idea, Very usefull for webp images with api gateway.

brignolij avatar Aug 31 '23 13:08 brignolij

@normj Thanks for your feedbacks

I just dit a new commit with following changes :

  • Add comments
  • Change the namespace of IEncodingOptions and EncodingOptions

For unit tests, what would be the best way to test the injection of IEncodingOptions ?

hugohlln avatar Sep 08 '23 09:09 hugohlln

@CamileDahdah

I just moved the registration of IEncodingOptions to LambdaRuntimeSupportServer level and removed redundant code from each AbstractAspNetCoreFunction<TREQUEST, TRESPONSE> implementations (APIGatewayHttpApiV2MinimalApi, APIGatewayRestApiMinimalApi and ApplicationLoadBalancerMinimalApi)

hugohlln avatar Sep 28 '23 10:09 hugohlln