aws-extensions-for-dotnet-cli icon indicating copy to clipboard operation
aws-extensions-for-dotnet-cli copied to clipboard

`quiet` option for package-ci

Open hauntingEcho opened this issue 3 years ago • 3 comments

Currently, when running lambda package-ci with --msbuild-parameters "-consoleloggerparameters:ErrorsOnly -verbosity:quiet -nologo", there is still a lot of log noise (e.g. ... zipping: Amazon.Kms.dll, ... Progress: 30%, Executing publish command, etc). Having an option to not print non-error log messages would be ideal.

Describe the Feature

A switch to only log errors, implying --msbuild-parameters "-consoleloggerparameters:ErrorsOnly -verbosity:quiet -nologo"

Is your Feature Request related to a problem?

When our developers deploy our whole product to a test environment, we are calling package-ci on a bunch of projects at once (currently 25). This generates a huge amount of log noise, which can make it hard to pick out errors

Proposed Solution

support --verbosity quiet to match the Dotnet CLI documentation.

Describe alternatives you've considered

  • just letting the logs all go to stdout and relying on devs to find the error
  • dumping the output of each package-ci call to separate log files, and telling the user to check them if there's a failure

Additional Context

I'm maintaining the CI/CD setup for a team, including local build/deployment scripts, and having less log noise would greatly simplify troubleshooting issues that others may have. This effectively blocks us from parallelizing the local build, since any issues will become lost in the noise of other executions.

Environment

  • [ ] :wave: I may be able to implement this feature request
  • [ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

hauntingEcho avatar Aug 25 '20 22:08 hauntingEcho

Need to discuss with team. May be supporting optional parameter to control verbose output in BundleWithBuildLambdaZip should help here.

ashishdhingra avatar Sep 22 '21 16:09 ashishdhingra

Hi @hauntingEcho,

Good morning.

I had this discussion with the team. We should not rely on MSBuild parameter to turn off AWS Lambda .NET CLI extensions specific logging. Instead there should be a new separate AWS Lambda .NET CLI extensions specific flag. Please advise if you would be able to submit a PR for this change.

Thanks, Ashish

ashishdhingra avatar Sep 27 '21 17:09 ashishdhingra

Hello, It's been over a year since I've really looked at this repository, and I'm not currently doing any work with lambdas, so it's unlikely that I'll be able to submit a PR in the near future. When you say "should not rely on MSBuild parameter", I'm curious what you're referring to? I had mentioned that it could be useful for:

  • setting the lambda extension's quiet switch to also quiet MSBuild calls made by the lambda extension
  • setting dotnet CLI's quiet switch to also quiet the lambda extension (and, by extension, MSBuild too)

hauntingEcho avatar Oct 05 '21 14:10 hauntingEcho

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

github-actions[bot] avatar Oct 06 '22 00:10 github-actions[bot]