aws-dotnet-extensions-configuration icon indicating copy to clipboard operation
aws-dotnet-extensions-configuration copied to clipboard

FIX ISSUE : IF Duplicate SSM parameter with different Case cause the whole SSM parameter fail to load

Open malah-code opened this issue 1 year ago • 4 comments

Fix issue #146 - SSM parameter case senstive but dotnet config is not, so if we have duplicate SSM parameters with different case, it will not load the ssm params at all.

Description

Fix issue (edge case), if we have duplicate SSM parameters with different case (like /param/one and /Param/ONE) like below parameter, the whole SSM parameters not added to the config at all, and it's completely ignored with no error message or log.

  • /Connection/OracleConnection
  • /Connection/ORACLECONNECTION
  • /connection/oracleconnection

Motivation and Context

this is fix an open issue with name "Duplicate SSM parameter with different Case cause the whole SSM parameter fail to load"

Testing

Before fix, create below SSM parameters

  • /Connection/OracleConnection
  • /Connection/ORACLECONNECTION
  • /Connection/anyOtherParam

Run the application to read from /Connection prefix, you will notice no ssm parameter loaded in the config even anyOtherParam. After apply fix, you will notice OracleConnection and anyOtherParam will appear in the dotnet config.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • [ Y] My code follows the code style of this project
  • [ N] My change requires a change to the documentation
  • [ N] I have updated the documentation accordingly
  • [ Y] I have read the README document
  • [ N] I have added tests to cover my changes
  • [Y ] All new and existing tests passed

License

  • [ Y] I confirm that this pull request can be released under the Apache 2 license

malah-code avatar May 04 '23 04:05 malah-code