aws-dotnet-deploy icon indicating copy to clipboard operation
aws-dotnet-deploy copied to clipboard

Deploy Tool Hangs Indefinitely When Docker Hangs

Open ashovlin opened this issue 1 year ago • 1 comments

Describe the bug

I'm trying to deploy a new application, but the deploy tool is hanging indefinitely here:

Choose deployment option (recommended default: 1)
3

Name the Cloud Application to deploy your project to
--------------------------------------------------------------------------------
Enter the name of the new CloudFormationStack stack (default WebAppWithDockerFile):

Expected Behavior

Deployment to proceed

Current Behavior

Upon investigation, the docker info we're running is hanging indefinitely as well

https://github.com/aws/aws-dotnet-deploy/blob/52f2ff48986a99f824ffcbd8b64beaa04452aed6/src/AWS.Deploy.Orchestration/SystemCapabilityEvaluator.cs#L51-L61

Reproduction Steps

Unsure why my Docker installation is stuck, it seems like Docker can hang for multiple reasons: https://github.com/docker/cli/issues/3433

It resolved itself once I did a factory reset of Docker Desktop.

Possible Solution

The deploy tool should be more resilient (set timeout on the child processes?) and display a helpful error message. For both docker info and node --version, I'd think we expect these to complete within a couple seconds.

Additional Information/Context

No response

Version used

1.14.6

Operating System and version

Windows 10

ashovlin avatar Aug 24 '23 15:08 ashovlin

Needs review. Makes sense to have a timeout (might be configurable via parameter) for the child processes to return.

ashishdhingra avatar Aug 24 '23 16:08 ashishdhingra

Fixed in https://github.com/aws/aws-dotnet-deploy/releases/tag/1.21.13 via #837, we now timeout at a minute for the Docker and Node checks.

ashovlin avatar Jul 08 '24 17:07 ashovlin

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

github-actions[bot] avatar Jul 08 '24 17:07 github-actions[bot]