aws-dax-go SendHandler does not populate the HTTPResponse

SendHandler does not populate the HTTPResponse

Open odannyc opened this issue 4 years ago • 3 comments

This library is not adding the HTTPResponse once we send off the request via the SendHandler. Look at the original aws-sdk-go for an example:

https://github.com/aws/aws-sdk-go/blob/main/aws/corehandlers/handlers.go#L112

Mar 24 '21 17:03 odannyc

@ktseytlin @kevinchristen

Can you guys provide some input on this?

I have other handlers that rely on HTTPResponse to be there and unfortunately this is not including it.

related: https://github.com/newrelic/go-agent/issues/287

Mar 25 '21 18:03 odannyc

DAX does not use HTTP. Can you give us more information about how your application relies on the response?

Mar 30 '21 17:03 kevinchristen

Thank you for responding back. There is a library (NewRelic) I'm using for tracing that relies on that field to be populated. Here is the code:

https://github.com/newrelic/go-agent/blob/master/_integrations/nrawssdk/v1/nrawssdk.go#L26-L29

Mar 30 '21 18:03 odannyc