aws-connected-device-framework
aws-connected-device-framework copied to clipboard
aws
fix(assetlibrary): add retry mechanism for connection error
Description
Since #168, we have occasionally encountered database connection errors. These errors are related to database connectivity, and in my opinion they should be retried in the AssetLibrary. In this Pull Request, I've added retry mechanism for connection errors.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Refactor (existing code being refactored)
- [ ] This change includes a documentation update
Submission Checklist
- [x] CI dry-run passing
- [x] Integration tests passing locally
- [x] Change logs generated
Additional Notes:
I feel like a more proper fix here would be to open the DB connection outside of the lambda handler (from here):
A common best practice is to open the database connection outside the Lambda handler function so that it can be reused with each handler call.
I feel like a more proper fix here would be to open the DB connection outside of the lambda handler (from here):
A common best practice is to open the database connection outside the Lambda handler function so that it can be reused with each handler call.
+1 to this.
@aaronatbissell @ts-amz Thank you for your suggestion. I understand the importance of reusing the DB connection with each handler call. I have structured the code in a way that allows the DB connection to be reused within the Lambda's execution context.
Is it necessary to open the DB connection outside of the Lambda handler? If we refer to the Neptune sample code here, we can see that they also open the DB connection in the lambda handler and reuse with each handler call.
If there are any specific concerns or aspects that you think I might have overlooked, please let me know.