aws-connected-device-framework icon indicating copy to clipboard operation
aws-connected-device-framework copied to clipboard

Device Monitoring: errors calling asset-library don't show as lambda errors

Open aaronatbissell opened this issue 2 years ago • 2 comments

Aws Connected Device Framework Affected Module(s):

device-monitoring

I'm submitting a ...

  • [x] bug report
  • [ ] feature request

Description:

When there is an error calling into asset library (specifically an Internal Server Error, but i'm sure other errors), that does not translate into a lambda error.

Current behavior:

When an error happens, the lambda still returns a successful return code

Expected behavior:

When an error happens, the lambda should return an unsuccessful return code

Steps to reproduce:

Additional Information:

Screen Shot 2023-02-21 at 11 00 58 AM Screen Shot 2023-02-21 at 11 00 01 AM

aaronatbissell avatar Feb 21 '23 16:02 aaronatbissell

@aaronatbissell Do you happen to know the block of code that causes the error or the steps to replicate?

This seems like a fairly simple thing to fix, unless it is an issue caused by incorrect data in the asset library.

anish-kunduru avatar Apr 26 '23 05:04 anish-kunduru

If I had to guess, it would be here. Looks like we just catch any errors, print a log message and move on. We should probably just throw there

aaronatbissell avatar Apr 26 '23 12:04 aaronatbissell