aws-codedeploy-agent icon indicating copy to clipboard operation
aws-codedeploy-agent copied to clipboard

fix changedir when unpacking tar/tgz

Open andogq opened this issue 1 year ago • 4 comments

Issue #, if available: N/A

Description of changes:

When running multiple deployments with a tar/tgz bundle on the same host with the same codeagent instance, there is a chance for a race condition at the DownloadBundle step where it may fail with a variety of error messages (eg):

  • Error extracting tar archive:
  • conflicting chdir during another chdir block

This change removes the use of FileUtils.cd when spawning the tar command in favour for tar's -C option which sets the changes the directory when running the command. This resolves any contention on the current directory as the directory is changed within each process' respective shells.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

andogq avatar Jun 04 '24 04:06 andogq

Can confirm this problem is affecting us in production and the proposed patch addresses the issue. Highly recommend 👍

dnjohnson avatar Jun 04 '24 06:06 dnjohnson

It is 3+ years and there is still no fully working version for ubuntu 22.04+ (https://github.com/aws/aws-codedeploy-agent/issues/301) - baffling Thx again to @moosthuizen42 for keeping codedeploy usable ...

sebastianreloaded avatar Sep 15 '24 20:09 sebastianreloaded

It looks like the fix is working, is this ever ganna get release?

alirezashtx avatar Jan 28 '25 09:01 alirezashtx

Hello, same issue here when I tried to update my instances from debian 11 to debian 12... As @alirezashtx asked, is this fix gonna be merged one day ?

Redeltaz avatar Feb 19 '25 10:02 Redeltaz

Hey can someone approve this? Would be incredibly helpful for my org.

jim-VT avatar Apr 28 '25 14:04 jim-VT