aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Modify debug migration s3 us-east-1 detections

Open aemous opened this issue 3 weeks ago • 1 comments

Description of changes:

  • Modify the us-east-1 S3 endpoint check so that:
    • It restricts the s3.amazonaws.com check to the hostname of the URL. This prevents false positives, for example, when the object key/prefix contains s3.amazonaws.com.
    • It does not trigger detection when --endpoint-url is used.
    • If the region is configured to something other than us-east-1, it will not trigger detection.
  • Switch changelog entry from enhancement type to feature.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aemous avatar Dec 10 '25 17:12 aemous

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.33%. Comparing base (5a98bdf) to head (49688a6). :warning: Report is 7 commits behind head on debug-migration.

Additional details and impacted files
@@               Coverage Diff                @@
##           debug-migration    #9906   +/-   ##
================================================
  Coverage            93.32%   93.33%           
================================================
  Files                  209      209           
  Lines                16909    16912    +3     
================================================
+ Hits                 15780    15784    +4     
+ Misses                1129     1128    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 10 '25 17:12 codecov-commenter