aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Add --include-file and --exclude-file options

Open tmccombs opened this issue 2 years ago • 4 comments

Fixes #5160

Add two new options to several s3 commands to include or exclude all patterns from a file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tmccombs avatar Apr 04 '23 07:04 tmccombs

Still needs tests. I haven't figured out how the tests are organized yet.

tmccombs avatar Apr 04 '23 07:04 tmccombs

merge the data field and vendor info. and do the selected file ratio and contability graph.

amberkushwaha931 avatar Apr 20 '23 05:04 amberkushwaha931

@amberkushwaha931 I don't understand what you are trying to say. what data field and vendor info? what is the selected file ratio and contability graph?

tmccombs avatar Apr 20 '23 15:04 tmccombs

Any update on this?

tmccombs avatar Jun 14 '24 04:06 tmccombs

Hey, thanks for this PR and for your patience. I brought this up to the team, and we've decided to close this as not planned. We'll be leaving the feature request (https://github.com/aws/aws-cli/issues/5160) open for tracking purposes, but we will not be merging this.

RyanFitzSimmonsAK avatar Jul 02 '24 21:07 RyanFitzSimmonsAK

What is the reason for not adding this feature?

Having to invoke the aws cli for each file individually is significantly slower, since you have to pay the cost of starting the python interpretor, loading modules, etc. Passing all the files on the command line is limited, because there is a maximum size for the command line.

The only viable option if you need to synchronize a large number of files is to write your own script using the SDK. But that involves having to duplicate a lot of what the CLI already does, especially if you want things like parallelization, conditional uploads/downloads, progress reporting, etc.

tmccombs avatar Jul 03 '24 02:07 tmccombs