aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Fix map shorthand docs issue, struct in a map should be wrapped in cu…

Open wangshu3000 opened this issue 2 years ago • 5 comments

Issue #: #3637

Description of changes:

This PR is to fix a shorthand doc issue. The struct type in the map should be wrapped in curly braces {}.

Doc url: https://docs.aws.amazon.com/cli/latest/reference/sqs/send-message.html

Before the change: KeyName1=DataType=string,StringValue=string,BinaryValue=blob

After the change: KeyName1={DataType=string,StringValue=string,BinaryValue=blob}

wangshu3000 avatar Sep 21 '22 01:09 wangshu3000

Can anybody please have a review? Is this repo still open to external contribution? Thanks.

wangshu3000 avatar Feb 21 '23 09:02 wangshu3000

Hi @kdaily and @dlm6693, would it be possible to have a look at this?

brianwarner avatar Nov 02 '23 18:11 brianwarner

Hi @tim-finnigan @kyleknap @kdaily

Would you please have a review on this PR? This it to fix the shorthand syntax issue in the cli doc. Both v1 and v2 all have this issue.

Thanks.

wangshu3000 avatar May 28 '24 07:05 wangshu3000

Yes. I will do the math and get back to you

On Tue, May 28, 2024, 02:21 Shu.Wang @.***> wrote:

Hi @tim-finnigan https://github.com/tim-finnigan @kyleknap https://github.com/kyleknap @kdaily https://github.com/kdaily

Would you please have a review on this PR? This it to fix the shorthand syntax issue in the cli doc. Both v1 and v2 all have this issue.

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/aws/aws-cli/pull/7286#issuecomment-2134514027, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4D26XPRW6HX3EDKTDQTZB3ZEQWATAVCNFSM6AAAAAAQRTKZHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGUYTIMBSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Me042589 avatar May 28 '24 07:05 Me042589