aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Add examples for GenerateDataKey* operations

Open juneb opened this issue 3 years ago • 3 comments

Description of changes: Ongoing project to improve the quality and coverage of KMS CLI examples.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

juneb avatar Jul 27 '22 22:07 juneb

Codecov Report

Merging #7141 (d96111e) into develop (df4ced6) will decrease coverage by 92.80%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #7141       +/-   ##
===========================================
- Coverage    92.88%   0.08%   -92.81%     
===========================================
  Files          204     205        +1     
  Lines        16351   16438       +87     
===========================================
- Hits         15188      14    -15174     
- Misses        1163   16424    +15261     
Impacted Files Coverage Δ
awscli/text.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/plugin.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/schema.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/handlers.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/paramfile.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/topictags.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/bcdoc/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/bcdoc/docevents.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/customizations/ecr.py 0.00% <0.00%> (-100.00%) :arrow_down:
awscli/customizations/iot.py 0.00% <0.00%> (-100.00%) :arrow_down:
... and 193 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 28 '22 00:07 codecov-commenter

Filed the required ticket with aws-docs: P69076988

juneb avatar Aug 02 '22 18:08 juneb

Hi June, Also responded to the ticket. A couple of minor fixes:

  • In generate-data-key-pair-without-plaintext.rst and generate-data-key-pair.rst in the code example you list --key-id twice. --key-id --key-id 1234abcd-12ab-34cd-56ef-1234567890ab \

  • In generate-data-key.rst you have multiple examples and are missing the Example 1: and Example 2: label.

elysahall avatar Aug 09 '22 20:08 elysahall

LGTM!

elysahall avatar Aug 12 '22 16:08 elysahall

Any reason for a delay on this PR?

juneb avatar Aug 30 '22 16:08 juneb

Merged these changes as part of #7254, closing this. Thanks again for the changes!

kdaily avatar Sep 07 '22 23:09 kdaily