Update colorama version for compatibility with pylint

[sbrunner]

Describe the bug

Install awscli with pylint at latest version (2.14.4) with e.g. poetry

Expected Behavior

Working

Current Behavior

I get the error:

  Because awscli (1.25.22) depends on colorama (>=0.2.5,<0.4.5)
   and pylint (2.14.4) depends on colorama (>=0.4.5), awscli (1.25.22) is incompatible with pylint (2.14.4).

Reproduction Steps

Install awscli with pylint at latest version (2.14.4) with e.g. poetry

Possible Solution

Update the colorama>=0.2.5,<0.4.5' dependency https://github.com/aws/aws-cli/blob/develop/setup.py

It looks like that just for security against new release.

Additional Information/Context

No response

CLI version used

1.25.22

Environment details (OS name and version, etc.)

Ubuntu 20.04

[tim-finnigan]

Hi @sbrunner thanks for reaching out. It looks like colorama v0.4.5 was just released on June 16, 2022: https://pypi.org/project/colorama/#history. We also had a recent PR to allow colorama upgrades up to v0.4.4. We’ll need to look through the changelog but this is something we should be able to update.

[naslundx]

Any updates on this? Also facing the same problem - it's not possible to use awscli and pylint in the same project.

[tim-finnigan]

Hi @naslundx thanks for checking in. The team is currently working on improving dependency management as it relates to the AWS CLI. There's another issue tracking that here: https://github.com/aws/aws-cli/issues/5943. I can't give a definite timeline but expect that in the near future colorama will be updated as part of this broader work.

[naslundx]

@tim-finnigan Thanks for the quick response!

[tim-finnigan]

Sure! I think this issue can now be closed as https://github.com/aws/aws-cli/pull/7380#pullrequestreview-1163820716 was just merged.

[glaubitz]

This should be bumped to at least colorama <= 0.4.6 as 0.4.6 is now the current version of the colorama package.

[tim-finnigan]

@glaubitz In that pr I referenced above the ceiling for colorama was set to <0.4.7 so 0.4.6 should be included.

[glaubitz]

Ah, I missed that reference. 0.4.7 sounds good. Thanks!

[github-actions[bot]]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

[tim-finnigan]

Reopening due to https://github.com/aws/aws-cli/pull/7395.

[bmw]

Will this change also be made for awscli v1?

[tim-finnigan]

@bmw dependabot was just recently added for v2 to increase version ranges like this one but it is not currently prioritized for v1.

[bmw]

Thanks for the info.

Since it seems v2 is usually installed in a separate environment with a bundled copy of Python, I suspect most people tracking this issue are interested in seeing it fixed for v1.

[gradientsky]

Conflict with tox:

$ pipdeptree -r -p colorama
Warning!!! Possibly conflicting dependencies found:
* tox==4.2.8
 - colorama [required: >=0.4.6, installed: 0.4.4]
------------------------------------------------------------------------
colorama==0.4.4
  - awscli==1.27.59 [requires: colorama>=0.2.5,<0.4.5]
  - tox==4.2.8 [requires: colorama>=0.4.6]

[aguckenber-chwy]

Still waiting on this fix.