aws-cli Add support for external-id in `aws eks get-token`

Add support for external-id in `aws eks get-token`

Open jbg opened this issue 3 years ago • 6 comments

Issue #5942

Description of changes: Add an optional --external-id parameter to aws eks get-token and pass it to AssumeRole.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Feb 25 '22 06:02 jbg

Any chance of getting a review on this? @justindho perhaps?

Jul 06 '22 04:07 jbg

LGTM

Sep 13 '23 04:09 kahirokunn

@kyleknap Could you please review this one? 🙇‍♂️

Sep 13 '23 05:09 kahirokunn

@yuxiang-zhang Do you have an example of a test?

Sep 20 '23 00:09 kahirokunn

@yuxiang-zhang Do you have an example of a test?

yeah inside tests/functional/eks/test_get_token.py

Sep 20 '23 15:09 yuxiang-zhang