aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

[v2] Add profile and role sorting to `sso configure`

Open ryansonshine opened this issue 3 years ago • 12 comments

Issue #, if available: Closes #6108

Description of changes: This change adds sorting to profiles and roles when running aws sso configure listing them in ascending alphabetical order by default (case insensitive).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ryansonshine avatar Jun 03 '21 17:06 ryansonshine

Codecov Report

Merging #6205 (66a7bac) into v2 (da94e8c) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6205      +/-   ##
==========================================
- Coverage   94.18%   94.11%   -0.07%     
==========================================
  Files         273      273              
  Lines       21678    21680       +2     
==========================================
- Hits        20417    20405      -12     
- Misses       1261     1275      +14     
Impacted Files Coverage Δ
awscli/customizations/configure/sso.py 100.00% <100.00%> (ø)
awscli/compat.py 60.81% <0.00%> (-2.45%) :arrow_down:
awscli/testutils.py 65.71% <0.00%> (-0.89%) :arrow_down:
awscli/table.py 95.07% <0.00%> (-0.76%) :arrow_down:
awscli/help.py 96.48% <0.00%> (-0.51%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da94e8c...66a7bac. Read the comment docs.

codecov-commenter avatar Jun 03 '21 17:06 codecov-commenter

@kdaily looking for any updates on when this will be merged

rayjanwilson avatar Oct 29 '21 14:10 rayjanwilson

Please merge this, it's soooo frustrating to look for the specific account when there are tens of them me the order changes every time...

simonweil avatar Nov 07 '21 21:11 simonweil

Please merge this, it's soooo frustrating to look for the specific account when there are tens of them me the order changes every time...

@kdaily is there a specific team that needs to review this? If so, can we ping them and get an update?

Issue #6108 has 35 :+1:'s and this PR hasn't seen an update for over 5 months, it's a bit discouraging for contributors to put in the time and effort to voluntarily implement functionality only for it to go ignored.

ryansonshine avatar Nov 09 '21 03:11 ryansonshine

@joguSD , is this something you're able to review?

ryansonshine avatar Nov 12 '21 04:11 ryansonshine

Any chance this feature graduates? It would be so helpful for my day to day as a heavy AWS user...

simonweil avatar Apr 03 '22 23:04 simonweil

Hi @ryansonshine thanks for the PR. Our team just put out a recent proposal in https://github.com/aws/aws-cli/pull/6828 detailing improvements to the contribution process. We are working through open PRs and have determined this PR to be in the Implementation stage (described here).

We are tracking this PR here on our project board and it can be set to to the review stage once new changes are ready to be reviewed. This will happen once we get through most of the open PRs and sort the open PRs against the criteria in our new contribution guide.

stealthycoin avatar Apr 19 '22 23:04 stealthycoin

Hi @stealthycoin,

any updates on this PR please ?

Thx

gmembre-zenika avatar Dec 08 '22 13:12 gmembre-zenika

Hello @stealthycoin

:up: please

Thanks a lot !

SebastienFourreau avatar Mar 14 '23 10:03 SebastienFourreau

Hi again !

Can someone do the necessary to review and merge this Pull Request please ? @stealthycoin / @kdaily

Thanks

SebastienFourreau avatar Aug 29 '23 13:08 SebastienFourreau

Hello,

this PR is opened since 2 years and no updates :-( What is wrong with it ? What can be done to merge it please ? @nateprewitt please ;-)

Regards

coliss86 avatar Dec 13 '23 07:12 coliss86

Any updates on this PR, please?

lteixeira-dock avatar Mar 11 '24 13:03 lteixeira-dock