aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

aws ecs deploy should incorporate time to shift traffic for wait time calculation

Open oliver-schoenherr opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe.

The aws ecs deploy command calculate the expected duration for a deployment based on the configured wait and termination time only, but in case of a canary deployment additional time is required to shift the traffic to the new version step by step. This leads to failed execution of the command, because the command gives up way to early - while the deployment is still not finished yet.

Describe the solution you'd like

Take the values of the traffic rerouting in consideration if the expected duration of the deployment is calculated.

Describe alternatives you've considered

Allow to override the expect deployment duration via some command line switch.

Additional context

https://aws.amazon.com/about-aws/whats-new/2020/02/amazon-elastic-container-service-support-canary-deployments/

oliver-schoenherr avatar Feb 21 '21 15:02 oliver-schoenherr

Thanks for the feature request and associated PR, @oliver-schoenherr.

kdaily avatar Feb 22 '21 22:02 kdaily

V323668604

kdaily avatar Feb 24 '21 18:02 kdaily

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

github-actions[bot] avatar Feb 24 '22 19:02 github-actions[bot]