aws-cli
aws-cli copied to clipboard
aws
Fix #1454 by optimizing number of S3 calls by using the prefix API parameter
Issue #, if available: #1454
This fix has the nice benefit of constructing filters once, but the downside of being horribly specific.
HI @ralph-tice - thanks for creating this PR and apology for the delay.
After reviewing this with the developer team, we'd need to discuss more on finding comprehensive approach rather than just addressing edge cases. If you're still interested, please rebase it against the latest branch for further discussion with the team going forward.
@aBurmeseDev heya, I'm still planning on rebasing this for further discussion FYI
Not sure what the dev team's thoughts are, but after sitting with this issue more and surveying the rest of the code, and given the low rate of change of this section of code over the last six years, I think it's fine to merge as-is. There's similarly specific fixes just a few lines below the meat of this change for deleting manually created "folders" while otherwise ignoring them for non-delete operations.
Checking in — thank you @ralph-tice for creating this PR and rebasing. Upon further discussion with the team, their stance is still that a more comprehensive approach is needed here as @aBurmeseDev mentioned. There are several S3 issues currently open involving s3 cp/sync and filtering, and more review is needed in order to come up with a more holistic plan for addressing these issues.
We may revisit the changes proposed here in the future and will continue tracking the issue in https://github.com/aws/aws-cli/issues/1454, but at this time the team decided that this PR should be closed. Thanks again for your contributions and patience here, we understand the frustrations around issues being open for long periods of time and we are trying to get better at addressing these.
