aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(kinesisfirehose): support custom time zone settings for S3 destination

Open Tietew opened this issue 5 months ago • 1 comments

Issue # (if applicable)

Closes #34737.

Reason for this change

Amazon Data Firehose supports to configure the time zone of timestamps in S3 object prefix. For details, see https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html#timestamp-namespace

Description of changes

Added the timeZone prop to S3BucketProps interface to set ExtendedS3Destination.CustomTimeZone. Note: Not in CommonProps since only ExtendedS3DestinationConfiguration supports time zone.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit test and integ test. I've confirmed setting timeZone reflects to Firehose's console.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Tietew avatar Jun 17 '25 09:06 Tietew

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

aws-cdk-automation avatar Jul 15 '25 00:07 aws-cdk-automation

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1093c7c09caa8825a0d6b5bb9d7aaa3512347177
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 15 '25 03:07 aws-cdk-automation

@ozelalisen Thank for review! I resolved conflicts.

Tietew avatar Jul 15 '25 06:07 Tietew

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 15 '25 08:07 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Jul 15 '25 08:07 github-actions[bot]