aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(core): `DockerBuildOptions` support network param

Open phuhung273 opened this issue 5 months ago • 1 comments

Issue # (if applicable)

Closes #34514

Reason for this change

DockerRunOptions has network param but DockerBuildOptions doesn't

Description of changes

DockerBuildOptions support network param

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Test DockerImage.fromBuild with python-alpha/test/integ.function.custom-build

$ ps aux | grep "docker build"
superch+ 44036  0.1  0.1 1994552 26112 pts/0   Sl+  08:20   0:00 docker build -t cdk-5322298f1d5d198bb67c2885f92ffc76a9e60f4ec4b584a8df116ebc75ebc843 --network default /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/lambda-handler-custom-build

Test PythonLayerVersion with python-alpha/test/integ.function.project

$ ps aux | grep "docker build"
superch+ 76129  100  0.1 1920308 24064 pts/0   Sl+  09:09   0:00 docker build -t cdk-858025f5c9bccadc11d046a66c283180089509773bb117d94236a7e2c03a0295 --platform linux/amd64 --network default --build-arg IMAGE=public.ecr.aws/sam/build-python3.13 /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

phuhung273 avatar Jun 15 '25 09:06 phuhung273

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8b3ccfb22546af2ecd29ec41210ee60540e9012e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 26 '25 02:07 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 27 '25 12:08 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 27 '25 12:08 github-actions[bot]