aws-cdk
aws-cdk copied to clipboard
feat(rds): instance engine lifecycle support
Issue # (if applicable)
Closes #34492
Reason for this change
Cluster has this param but Instance doesn't
Description of changes
- Instance engine lifecycle support
- Move enum EngineLifecycleSupport to props as it is shared across cluster and instance
Describe any new or updated permissions being added
Description of how you validated changes
Unit + Integ
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Thanks for your review @go-to-k 💯
Thanks @leonmk-aws. There was a small issue with the integ, would you mind reapprove mate ?
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 6e52d2657c83398d150c64c189bf065c045b6e2d
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.