aws-cdk
aws-cdk copied to clipboard
feat(eks-v2-alpha): support eks with k8s 1.33
Issue # (if applicable)
Closes #34520
Reason for this change
Description of changes
- Support version 1.33
- Add support for AL2023 EKS optimized AMI + user data since 1.33 no longer support AL2. I believe this change should also be included in v1 module. Please let me know if you guys agree, happy to open another PR adding this to v1
- Fix failing integration tests
- Upgrade dependencies: cdk8s-plus-32
Describe any new or updated permissions being added
Description of how you validated changes
Unit + Integ
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Why did this PR not make the latest release? We are now pushing a month after the AWS release and unable to deploy and I'd rather not rewrite my deploy to use the old EKS module.
@darylgraham you can help speed up the process by dropping a like on the issue #34520, CDK team track issue based on react
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 1c34f4a922b1c11e393538f4bd6ee1127f1b5dc5
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Hi @pahud, sorry to ping you directly. I just want to know your thought, the team can review later.
Im aware that this change contains more than just a new version, making it more difficult for reviewer. Even I dont want to do so. But still did it since:
- Managed NodeGroup >= 1.33 no longer support AL2, making some integration tests fail
- I followed your instruction carefully https://github.com/aws/aws-cdk/pull/33344#issuecomment-2648943128 to ensure all integration passed for v2 alpha package (v1 only minimal change). IMO, this is a good way so we can can ensure better coverage for v2 alpha.
But if the team think we should keep it small, I'm happy to exclude AL2023 change. Please advise me on how we should proceed.
@phuhung273 Thank you for reaching out. Yes I am onboard to have minimal required change to include 1.33 support. I will reach out to the maintainer today for their inputs here.
Thanks so much @pahud for your help 🍻
Hi @phuhung273 , thank you for your contribution! Let's keep the PR focused on a single change, and then create a separate PR for the unrelated changes. Generally we put multiple changes in a single PR only if there is some dependency which prevents breaking them up into multiple PRs.
Thank you @vishaalmehrishi @pahud for your advice, appreciate. I've updated to only add new version and as many integration tests as possible.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.