aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(cognito): support refresh token rotation

Open iridescent99 opened this issue 7 months ago • 2 comments

Issue # (if applicable)

Closes #34344

Reason for this change

Cognito added support for short-lived refresh tokens.

Description of changes

Added refreshTokenRotation property to UserPoolClient

Describe any new or updated permissions being added

NA

Description of how you validated changes

Unit + integrationt tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

iridescent99 avatar May 05 '25 20:05 iridescent99

Anyone willing to take a look?

iridescent99 avatar May 16 '25 19:05 iridescent99

Thank you for your feedback. I incorporated the changes, please let me know if it reflects your suggestions

iridescent99 avatar Jun 19 '25 18:06 iridescent99

@leonmk-aws Thank you for your patience, I made the changes.

iridescent99 avatar Jun 24 '25 16:06 iridescent99

@leonmk-aws ok another attempt

iridescent99 avatar Jun 25 '25 15:06 iridescent99

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Jul 06 '25 00:07 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Jul 07 '25 00:07 aws-cdk-automation

It seems folders / code were added when solving a merge conflicts can we remove these ?

leonmk-aws avatar Jul 17 '25 09:07 leonmk-aws

Thanks! This okay?

iridescent99 avatar Jul 30 '25 19:07 iridescent99

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 04 '25 08:08 mergify[bot]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Aug 04 '25 08:08 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 83e770ad5640b1200d9c9fa5a76ccfb54d9dc33d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 06 '25 19:08 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 25 '25 08:08 mergify[bot]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Aug 25 '25 08:08 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 25 '25 09:08 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 25 '25 09:08 github-actions[bot]