aws-cdk
aws-cdk copied to clipboard
feat(events): add `arnForPolicy` attribute for api destination
Issue # (if applicable)
None
Reason for this change
L1 construct has arnForPolicy attribute but L2 construct does not support this.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-apidestination.html#aws-resource-events-apidestination-return-values#aws-resource-events-apidestination-return-values-fn--getatt
Description of changes
- Add
apiDestinationArnForPolicytoApiDestinationAttributesand attribute ofIApiDestination
Describe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
@QuantumNeuralCoder Could you please confirm this PR again?
@mergify update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-upload.yml without workflows permission
@ozelalisen Could you please approve this again ?
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
This pull request has been removed from the queue for the following reason: pull request dequeued.
Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).
You can check the last failing draft PR here: #34939.
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.
@mergifyio requeue
requeue
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically
This pull request has been removed from the queue for the following reason: pull request dequeued.
Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).
You can check the last failing draft PR here: #34954.
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.
@mergify update
update
✅ Branch has been successfully updated
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: c44b1186005d9bfe2e949a653c6fd81f05b1565c
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.