aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(events): add `arnForPolicy` attribute for api destination

Open badmintoncryer opened this issue 7 months ago • 2 comments

Issue # (if applicable)

None

Reason for this change

L1 construct has arnForPolicy attribute but L2 construct does not support this.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-apidestination.html#aws-resource-events-apidestination-return-values#aws-resource-events-apidestination-return-values-fn--getatt

Description of changes

  • Add apiDestinationArnForPolicy to ApiDestinationAttributes and attribute of IApiDestination

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer avatar Apr 30 '25 11:04 badmintoncryer

@QuantumNeuralCoder Could you please confirm this PR again?

badmintoncryer avatar May 08 '25 00:05 badmintoncryer

@mergify update

badmintoncryer avatar Jul 09 '25 12:07 badmintoncryer

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-upload.yml without workflows permission

mergify[bot] avatar Jul 09 '25 12:07 mergify[bot]

@ozelalisen Could you please approve this again ?

badmintoncryer avatar Jul 10 '25 02:07 badmintoncryer

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 10 '25 09:07 mergify[bot]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34939.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you do update this pull request, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Jul 10 '25 09:07 mergify[bot]

@mergifyio requeue

ozelalisen avatar Jul 10 '25 13:07 ozelalisen

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify[bot] avatar Jul 10 '25 13:07 mergify[bot]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34315 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.).

You can check the last failing draft PR here: #34954.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you do update this pull request, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Jul 10 '25 15:07 mergify[bot]

@mergify update

badmintoncryer avatar Jul 10 '25 15:07 badmintoncryer

update

✅ Branch has been successfully updated

mergify[bot] avatar Jul 10 '25 15:07 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c44b1186005d9bfe2e949a653c6fd81f05b1565c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 10 '25 15:07 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 10 '25 15:07 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Jul 10 '25 17:07 github-actions[bot]