aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(route53-patterns): `HttpsRedirect` use `Distribution` as the default CloudFront distribution (under feature flag)

Open phuhung273 opened this issue 7 months ago • 1 comments

Issue # (if applicable)

Closes #31546

Reason for this change

CloudFrontWebDistribution is deprecated

Description of changes

HttpsRedirect use Distribution instead of deprecated CloudFrontWebDistribution under feature flag

Please check template comments for explanation on each removed param:

  • Most of them are safe to remove since most are default
  • ForwardedValues is deprecated and replaced by CachePolicyId

Description of how you validated changes

Unit + Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

phuhung273 avatar Apr 30 '25 05:04 phuhung273

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fa0caaacf3ec2618b337990644c54b2fabe2bda3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 27 '25 02:07 aws-cdk-automation

Hi @phuhung273 I think you may wan to resolve the tiny conflict first?

pahud avatar Nov 11 '25 19:11 pahud

Thanks @pahud for taking a look. It would be great if you can help get this PR moving. I've been waiting for quite a time.

phuhung273 avatar Nov 11 '25 22:11 phuhung273

@phuhung273 Awesome! I can see this PR is all clear and in the reviewing backlog as "Ready" state. It should be reviewed very soon. I will request the team to take a look and reprioritize if necessary.

pahud avatar Nov 11 '25 23:11 pahud