aws-cdk
aws-cdk copied to clipboard
feat(route53-patterns): `HttpsRedirect` use `Distribution` as the default CloudFront distribution (under feature flag)
Issue # (if applicable)
Closes #31546
Reason for this change
CloudFrontWebDistribution is deprecated
Description of changes
HttpsRedirect use Distribution instead of deprecated CloudFrontWebDistribution under feature flag
Please check template comments for explanation on each removed param:
- Most of them are safe to remove since most are default
ForwardedValuesis deprecated and replaced byCachePolicyId
Description of how you validated changes
Unit + Integ
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: fa0caaacf3ec2618b337990644c54b2fabe2bda3
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Hi @phuhung273 I think you may wan to resolve the tiny conflict first?
Thanks @pahud for taking a look. It would be great if you can help get this PR moving. I've been waiting for quite a time.
@phuhung273 Awesome! I can see this PR is all clear and in the reviewing backlog as "Ready" state. It should be reviewed very soon. I will request the team to take a look and reprioritize if necessary.