feat(events-targets): support Amazon Data Firehose target using Firehose's `IDeliveryStream`
Issue # (if applicable)
Related to #33757 and #33758
Reason for this change
The module has the KinesisFirehoseStreamV2 target class for Firehose delivery stream.
But it has following issues:
- Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class should not be called Kinesis. Also, KinesisFirehoseStream is confusable with Kinesis Data Stream.
- The constructor receives internally defined
IDeliveryStreamwhich is a subset ofaws_kinesisfirehose.IDeliveryStreamwithout inheritance. This may cause jsii type compatibility problem.
Description of changes
- Added a new
FirehoseDeliveryStreamtarget class derived fromKinesisFirehoseStreamV2but receivesaws_kinesisfirehose.IDeliveryStreaminstead. - Deprecated
KinesisFirehoseStreamV2and internalIDeliveryStream. - Added missing unit tests for
FirehoseDeliveryStream - Updated the integ test to use
FirehoseDeliveryStreamand assertions. - Added an missing README entry refers Amazon Data Firehose.
Describe any new or updated permissions being added
N/A - FirehoseDeliveryStream adds same permissions as KinesisFirehoseStreamV2
Description of how you validated changes
Unit tests and integ test.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.39%. Comparing base (
a67c3f5) to head (286b140).
Additional details and impacted files
@@ Coverage Diff @@
## main #33798 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 120 120
Lines 6960 6960
Branches 1175 1175
=======================================
Hits 5735 5735
Misses 1120 1120
Partials 105 105
| Flag | Coverage Δ | |
|---|---|---|
| suite.unit | 82.39% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| packages/aws-cdk | ∅ <ø> (∅) |
|
| packages/aws-cdk-lib/core | 82.39% <ø> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: e566700ceeca137bc573ab0e49f4f9d5526294bc
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-collect.yml without workflows permission
@Abogical Updated the snapshot.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
This pull request has been removed from the queue for the following reason: pull request branch update failed.
The pull request can't be updated.
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.
@mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/pr-build.yml without workflows permission
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@mergifyio requeue
requeue
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.