aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(event-targets): add role property to sqs event target

Open atnartur opened this issue 9 months ago • 6 comments

Reason for this change

Add role property to SQS Event Target in EventBridge

Description of changes

Add role attribute to SQS Event Target in EventBridge which is available in AWS CloudFormation template but was not available in AWS CDK.

Describe any new or updated permissions being added

No changes in permissions are made.

Description of how you validated changes

Deploy an EventBridge Rule with SQS Event Target and custom role.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

atnartur avatar Mar 06 '25 16:03 atnartur

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.24%. Comparing base (77b6fa9) to head (06acad4). Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33701   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files         119      119           
  Lines        6875     6875           
  Branches     1161     1161           
=======================================
  Hits         5654     5654           
  Misses       1118     1118           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.24% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 07 '25 18:03 codecov[bot]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

aws-cdk-automation avatar Apr 03 '25 00:04 aws-cdk-automation

Related to #33827 #33976

atnartur avatar Apr 03 '25 14:04 atnartur

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

aws-cdk-automation avatar Apr 25 '25 00:04 aws-cdk-automation

Clarification Request: Hi! I'm receiving the message that my PR will be closed soon due to the test failure, but tests are also failing on the main branch.

atnartur avatar Apr 25 '25 09:04 atnartur

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8341a95b00248b0901a90075f429078c0377b34f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar May 23 '25 16:05 aws-cdk-automation

Hi @shikha372! Could you please take a look at this PR?

atnartur avatar Jul 02 '25 19:07 atnartur

Hi,

This PR has conflicts that need to be resolved before it can be reviewed.

pahud avatar Nov 11 '25 19:11 pahud

Hi @pahud, I fixed the merge conflict. Could you please have a look?

atnartur avatar Nov 12 '25 21:11 atnartur