aws-cdk
aws-cdk copied to clipboard
chore(cli): remove redundant ts compiler options from cdk init
Issue # (if applicable)
n/a
Reason for this change
To simplify the typescript template generated from cdk init command.
Description of changes
This PR removes four redundant options that are already enabled by strict option, i.e. noImplicitAny, strictNullChecks, noImplicitThis, and alwaysStrict. These options are set totrue by default when strict is true.
(example)
I also deleted a tsconfig.json for javascript sample-app template becaue we should not need it.
Description of how you validated changes
TSConfig Reference describes about the defaults.
Checklist
- [X] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: ffa3baaaf764efafdd59319c005df961e4bd7e3a
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
closing this in favor of #31927
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.