aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

chore(cli): remove redundant ts compiler options from cdk init

Open tmokmss opened this issue 1 year ago • 1 comments

Issue # (if applicable)

n/a

Reason for this change

To simplify the typescript template generated from cdk init command.

Description of changes

This PR removes four redundant options that are already enabled by strict option, i.e. noImplicitAny, strictNullChecks, noImplicitThis, and alwaysStrict. These options are set totrue by default when strict is true.

(example) image

I also deleted a tsconfig.json for javascript sample-app template becaue we should not need it.

Description of how you validated changes

TSConfig Reference describes about the defaults.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

tmokmss avatar Oct 18 '24 06:10 tmokmss

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ffa3baaaf764efafdd59319c005df961e4bd7e3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Oct 18 '24 07:10 aws-cdk-automation

closing this in favor of #31927

tmokmss avatar Oct 30 '24 14:10 tmokmss

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Oct 30 '24 14:10 github-actions[bot]