aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

chore(custom-resources): corrected the AWS SDK v2 to v3 mapping for memorydb service.

Open ashishdhingra opened this issue 1 year ago • 2 comments

Issue # (if applicable)

Closes #31755.

Reason for this change

Per MemoryDBClient, the service name is memorydb (not memory-db) with package name as @aws-sdk/client-memorydb. However, sdk-v2-to-v3.json is using wrong v3 service name for memorydb, which is causing failure to load package. Refer https://github.com/aws/aws-cdk/issues/31755#issuecomment-2414930902 for more details.

Description of changes

Corrected the mapping for v3 service name for memorydb in the sdk-v2-to-v3.json. Unsure if packages/aws-cdk-lib/custom-resources/lib/helpers-internal/sdk-v2-to-v3.json is used now, but modifying it anyway.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

ashishdhingra avatar Oct 15 '24 21:10 ashishdhingra

Please add an integration test for this one that uses the reproduction: #31755

@comcalvi Added integration test for AWS customer resource for memorydb service. I rebased from main, now integration tests are failing with changed snapshots. Please advise.

ashishdhingra avatar Oct 19 '24 02:10 ashishdhingra

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8cffc3226c7b591b8511f5db4a989a54a60cd081
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Oct 24 '24 04:10 aws-cdk-automation

Abandoning this PR in favor of https://github.com/aws/aws-cdk/pull/31874.

ashishdhingra avatar Oct 24 '24 06:10 ashishdhingra

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Oct 24 '24 06:10 github-actions[bot]