aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(redshift-alpha): issue #31634: add support for RA3.large node type

Open AsadBinImtiaz opened this issue 1 year ago • 4 comments

Issue # (if applicable)

Closes #31634.

Reason for this change

add support for RA3.large node type

Description of changes

extended the NodeType enum in ClusterProps.nodeType to include RA3.large

Description of how you validated changes

ran all tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

AsadBinImtiaz avatar Oct 03 '24 17:10 AsadBinImtiaz

The value ra3.large for NodeType is not yet available for AWS::Redshift::Cluster resource in CloudFormation per aws-redshift-cluster.json. This schema JSON file was last updated 2 months ago as of now. Please wait until the schema is updated and CloudFormation resource accepts ra3.large as valid NodeType.

ashishdhingra avatar Oct 03 '24 21:10 ashishdhingra

Hi @ashishdhingra ,

Thank you for the feedback. I understand that the aws-redshift-cluster.json schema file has not been updated yet. However, I have successfully created an RA3.large Redshift cluster using the CDK in my integration test, which indicates that CloudFormation is indeed accepting RA3.large as a valid node type.

Here are the steps I followed:

  • I created a CDK stack using the changes in my PR, specifying RA3.large as the NodeType.
  • The stack successfully deployed in my AWS account, and the Redshift cluster was provisioned without issues.
  • The integration test passed, confirming that CloudFormation accepted RA3.large as a valid NodeType.

Would it be possible that the CloudFormation schema and the documentation haven't been updated yet, even though the backend already supports this new instance type?

AsadBinImtiaz avatar Oct 04 '24 13:10 AsadBinImtiaz

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Oct 21 '24 00:10 aws-cdk-automation

Waiting on PR: https://github.com/cdklabs/awscdk-service-spec/pull/1421

AsadBinImtiaz avatar Nov 08 '24 18:11 AsadBinImtiaz

The missing value ra3.large for is now available in AWS::Redshift::Cluster

AsadBinImtiaz avatar Nov 27 '24 14:11 AsadBinImtiaz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.67%. Comparing base (57cbd86) to head (a414361). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #31637   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5694     5694           
  Misses       1357     1357           
  Partials      186      186           
Flag Coverage Δ
suite.unit 78.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.67% <ø> (ø)

codecov[bot] avatar Dec 06 '24 11:12 codecov[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 07 '24 00:12 mergify[bot]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify[bot] avatar Dec 07 '24 02:12 mergify[bot]

@Mergifyio update

gracelu0 avatar Dec 09 '24 19:12 gracelu0

update

✅ Branch has been successfully updated

mergify[bot] avatar Dec 09 '24 19:12 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 09 '24 19:12 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 09 '24 20:12 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a414361a80e95e7c476e9f493651e22237f06a78
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Dec 10 '24 17:12 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 10 '24 17:12 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Dec 10 '24 17:12 github-actions[bot]