aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

Published 20 hours ago • verified publisher icon aws

fix(opensearchservice): support r7gd, i4i and i4g in aws_opensearchservice

Open sharp-pixel opened this issue 1 year ago • 3 comments

Issue # (if applicable)

Closes #.

Reason for this change

R7GD, I4I and I4G have instance storage and do not support EBS. However there is a list in aws_opensearchservice with allowlisted values to support instances with no EBS.

Description of changes

This pull requests updates the checks made on instance type without EBS to include i4i, i4g and r7gd. Also fixed some deprecations.

Description of how you validated changes

Deployed an OpenSearch domain with r7gd using modified version of CDK, + unit tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

sharp-pixel avatar Sep 25 '24 21:09 sharp-pixel

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe1d4e5f62b719a58016a2341800f396bc8b0488
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Oct 15 '24 17:10 aws-cdk-automation

Any idea when this might be merged?

Battleroid avatar Oct 17 '24 17:10 Battleroid

@Battleroid could you please help the team by reviewing this PR. Our team prioritize the PRs that are already reviewed by the community.

moelasmar avatar Oct 17 '24 17:10 moelasmar

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Nov 03 '24 00:11 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Nov 04 '24 00:11 aws-cdk-automation

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Nov 10 '24 00:11 aws-cdk-automation

Some of this has already been merged. Closing this one.

sharp-pixel avatar Nov 16 '24 10:11 sharp-pixel

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Nov 16 '24 10:11 github-actions[bot]