aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(vpcv2): implementation of add gateway method

Open shikha372 opened this issue 1 year ago • 1 comments

Issue # (if applicable)

Closes #.

Reason for this change

implementing below methods for vpcV2. addEgressOnlyInternetGateway addInternetGateway addNatGateway enableVPNGatewayV2

Additional changes: -> Modify Readme -> Separate ipam related Tests

Allows user to define gateways in their vpc with a simple method and an optional default route setup on provided subnets

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

shikha372 avatar Aug 26 '24 19:08 shikha372

Only half way through.

I'm a bit worried by the number of breaking changes. I understand it is an alpha module and breaking changes are allowed. However, a number of changes are removing an old construct and introduced V2, i.e. VPNGateway is removed and introduced VPNGatewayV2. It's breaking changes anyway, should we just use the same name?

So one is compatible with Route construct and other lives in the main lib VPNGateway is not implementing IRouteTarget so that can not be set as an target while defining a route. So, the V2 is aligned with features (i.e. Route and RouteTable) in this new module, it is more clear that this is latest. Also, if there is already a construct with same name in main lib, not sure if its best practice to introduce another with same name as it can create issue with graduation.

shikha372 avatar Sep 05 '24 07:09 shikha372

@mergifyio update

shikha372 avatar Sep 12 '24 15:09 shikha372

update

✅ Branch has been successfully updated

mergify[bot] avatar Sep 12 '24 15:09 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f30e1da51cdbc8a127b9f09737c2620f9552a7e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 12 '24 16:09 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 12 '24 16:09 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Sep 12 '24 16:09 github-actions[bot]