aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(stepfunctions-tasks): sageMakerCreateTrainingJob does not correctly support empty inputDataConfig

Open xazhao opened this issue 1 year ago • 1 comments

Issue # (if applicable)

Closes #31132.

Reason for this change

inputDataConfig is not a required property in the API: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateTrainingJob.html#sagemaker-CreateTrainingJob-request-InputDataConfig

However in SageMakerCreateTrainingJob, it's marked as required. We should make it align with the API.

Description of changes

Make the property optional.

Description of how you validated changes

unit test and integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

xazhao avatar Aug 23 '24 22:08 xazhao

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 30 '24 21:08 mergify[bot]

@Mergify update

xazhao avatar Aug 30 '24 21:08 xazhao

update

☑️ Nothing to do

  • [ ] #commits-behind>0 [📌 update requirement]
  • [X] -closed [📌 update requirement]
  • [X] -conflict [📌 update requirement]
  • [X] queue-position=-1 [📌 update requirement]

mergify[bot] avatar Aug 30 '24 21:08 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 03 '24 17:09 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fcdec41319c19b6a7377fb0790d9383d2008c39a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 03 '24 18:09 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 03 '24 18:09 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Sep 03 '24 18:09 github-actions[bot]