aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(dynamodb): replication regions are incompatible with resource policies in TableV2

Open LeeroyHannigan opened this issue 1 year ago • 2 comments

Issue # (if applicable)

Closes #30705

Reason for this change

Resource policies were shared across all replicas in a region.

Description of changes

Changed the logic to only apply resource policy to the local replica region, or to specific replicas only when defined.

Description of how you validated changes

Unit tests were conducted

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

LeeroyHannigan avatar Aug 13 '24 17:08 LeeroyHannigan

The issue is defined in #31097

Do you require more information than is supplied there?

LeeroyHannigan avatar Aug 20 '24 18:08 LeeroyHannigan

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 973a3799a8a68e71678df084a8f7336023e8f6a3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 28 '24 15:08 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Sep 16 '24 00:09 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Sep 17 '24 00:09 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar Sep 18 '24 00:09 aws-cdk-automation

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Sep 19 '24 00:09 aws-cdk-automation

Had some issues with building so pushed a fresh version https://github.com/aws/aws-cdk/pull/31513

LeeroyHannigan avatar Sep 20 '24 19:09 LeeroyHannigan

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Sep 20 '24 19:09 github-actions[bot]