aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag)

Open sarangarav opened this issue 1 year ago • 1 comments

Issue # (if applicable)

Closes #28915

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested, integration and unit tested the changes

yes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

sarangarav avatar Jun 28 '24 20:06 sarangarav

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f39ae7ad615b5c7cf8f1640dc356644e965d874e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 02 '24 19:07 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 02 '24 20:07 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

aws-cdk-automation avatar Jul 25 '24 17:07 aws-cdk-automation