aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(ec2): add g6 instance

Open mellevanderlinde opened this issue 1 year ago • 4 comments

Issue # (if applicable)

Closes #30683

Reason for this change

G6 instances are not yet supported by CDK L2

Description of changes

Added G6 instance class

Description of how you validated changes

Added g6 to existing unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mellevanderlinde avatar Jun 27 '24 13:06 mellevanderlinde

Would this small change qualify for an "Exemption Request"? An integration test might not be required for adding an instance class

mellevanderlinde avatar Jun 27 '24 13:06 mellevanderlinde

Would this small change qualify for an "Exemption Request"? An integration test might not be required for adding an instance class

Yeah, no integration test is needed here.

msambol avatar Jun 28 '24 14:06 msambol

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d793ce54036cdaec0beddb6949c9f4fd702ebda9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 18 '24 18:07 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 18 '24 18:07 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

aws-cdk-automation avatar Jul 25 '24 17:07 aws-cdk-automation