aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(eks): support CUSTOM amiType

Open Artemigos opened this issue 1 year ago • 1 comments

Issue # (if applicable)

Closes #30641.

Reason for this change

Node groups with custom AMI are supported by CloudFormation, but not by CDK. This adds that support.

Description of changes

  • added CUSTOM to the NodegroupAmiType enum
  • always add CUSTOM to possibleAmiTypes when validating instanceTypes CPU architecture against amiType
  • verify that launchTemplateSpec is defined when using CUSTOM

Description of how you validated changes

Added unit tests checking valid deployment as well as failure when CUSTOM is used, but launchTemplateSpec isn't defined.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Artemigos avatar Jun 25 '24 12:06 Artemigos

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 432ead4c4c5786a379005f5bd08f0ee8d5b2d58d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 12 '24 12:08 aws-cdk-automation

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Oct 12 '24 00:10 aws-cdk-automation

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation avatar Oct 19 '24 00:10 aws-cdk-automation

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Oct 19 '24 00:10 github-actions[bot]