feat(ec2): security group lookup via filters
Issue # (if applicable)
Closes #30331.
Reason for this change
This will improve the security group lookup functionality for importing existing security groups into a CDK stack.
Description of changes
I added the ability to lookup existing security groups via more filters. Filters are supported by the DescribeSecurityGroups API, and using these filters can be immensely useful for looking up existing security groups, especially if your account or organization follows predictable rules regarding things like security group tags.
Description of how you validated changes
I added unit tests similar to the ones that test the normal lookup by ID or name.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Clarification Request
Does this feature need a new integration test? If so, I'm struggling to figure out how to write one for a lookup like this.
Exemption Request
Hi there, I happened to be looking at this while you merged from main. In general, to do so please use the mergify command instead of using the button. @Mergifyio update
Hi there, I happened to be looking at this while you merged from main. In general, to do so please use the mergify command instead of using the button.
@Mergifyio update
@TheRealAmazonKendra Will do. Out of curiosity, why is that preferred?
@Mergifyio update
update
✅ Branch has been successfully updated
@Mergifyio update
update
✅ Branch has been successfully updated
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
@Mergifyio update
update
✅ Branch has been successfully updated
@Mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission
@Mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission
@Mergifyio update
update
✅ Branch has been successfully updated
@Mergifyio update
update
✅ Branch has been successfully updated
All tests passed. Adding the cli tested label.
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: dd9049709e749926f5a51a3b473266f21c4ddef7
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.
We are now using an externally published version of cloud assembly schema. This needs to be reverted as it conflicts with that.