aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(ec2): security group lookup via filters

Open jdukewich opened this issue 1 year ago • 4 comments

Issue # (if applicable)

Closes #30331.

Reason for this change

This will improve the security group lookup functionality for importing existing security groups into a CDK stack.

Description of changes

I added the ability to lookup existing security groups via more filters. Filters are supported by the DescribeSecurityGroups API, and using these filters can be immensely useful for looking up existing security groups, especially if your account or organization follows predictable rules regarding things like security group tags.

Description of how you validated changes

I added unit tests similar to the ones that test the normal lookup by ID or name.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jdukewich avatar Jun 22 '24 18:06 jdukewich

Clarification Request

Does this feature need a new integration test? If so, I'm struggling to figure out how to write one for a lookup like this.

jdukewich avatar Jun 23 '24 18:06 jdukewich

Exemption Request

jdukewich avatar Jun 29 '24 19:06 jdukewich

Hi there, I happened to be looking at this while you merged from main. In general, to do so please use the mergify command instead of using the button. @Mergifyio update

TheRealAmazonKendra avatar Jul 03 '24 17:07 TheRealAmazonKendra

Hi there, I happened to be looking at this while you merged from main. In general, to do so please use the mergify command instead of using the button. @Mergifyio update

@TheRealAmazonKendra Will do. Out of curiosity, why is that preferred?

jdukewich avatar Jul 03 '24 17:07 jdukewich

@Mergifyio update

jdukewich avatar Jul 08 '24 12:07 jdukewich

update

✅ Branch has been successfully updated

mergify[bot] avatar Jul 08 '24 12:07 mergify[bot]

@Mergifyio update

jdukewich avatar Jul 10 '24 14:07 jdukewich

update

✅ Branch has been successfully updated

mergify[bot] avatar Jul 10 '24 14:07 mergify[bot]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Jul 14 '24 00:07 aws-cdk-automation

@Mergifyio update

jdukewich avatar Jul 15 '24 13:07 jdukewich

update

✅ Branch has been successfully updated

mergify[bot] avatar Jul 15 '24 13:07 mergify[bot]

@Mergifyio update

jdukewich avatar Jul 17 '24 20:07 jdukewich

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission

mergify[bot] avatar Jul 17 '24 20:07 mergify[bot]

@Mergifyio update

jdukewich avatar Jul 17 '24 20:07 jdukewich

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission

mergify[bot] avatar Jul 17 '24 20:07 mergify[bot]

@Mergifyio update

xazhao avatar Aug 06 '24 19:08 xazhao

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 06 '24 19:08 mergify[bot]

@Mergifyio update

xazhao avatar Aug 07 '24 21:08 xazhao

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 07 '24 21:08 mergify[bot]

All tests passed. Adding the cli tested label.

xazhao avatar Aug 07 '24 21:08 xazhao

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dd9049709e749926f5a51a3b473266f21c4ddef7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 07 '24 21:08 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 07 '24 22:08 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 07 '24 22:08 github-actions[bot]

We are now using an externally published version of cloud assembly schema. This needs to be reverted as it conflicts with that.

TheRealAmazonKendra avatar Aug 08 '24 18:08 TheRealAmazonKendra