aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(apprunner): support vpc ingress connection

Open mazyu36 opened this issue 1 year ago • 3 comments

Issue # (if applicable)

Closes #22850.

Reason for this change

To support VPC Ingress Connection for making App Runner Service private and only accessible from within a VPC.

Description of changes

  • Add isPubliclyAccessible property to the Service class
  • Add VpcIngressConnection class

Description of how you validated changes

Add unit tests and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mazyu36 avatar Jun 22 '24 09:06 mazyu36

@Mergifyio update

mazyu36 avatar Jun 25 '24 00:06 mazyu36

update

☑️ Nothing to do

  • [ ] #commits-behind>0 [📌 update requirement]
  • [X] -closed [📌 update requirement]
  • [X] -conflict [📌 update requirement]
  • [X] queue-position=-1 [📌 update requirement]

mergify[bot] avatar Jun 25 '24 00:06 mergify[bot]

@lpizzinidev Thanks. I've addressed your comments.

mazyu36 avatar Jul 31 '24 16:07 mazyu36

@paulhcsun Thank you for the review! I've addressed the comments.

mazyu36 avatar Oct 29 '24 01:10 mazyu36

@mergifyio update

paulhcsun avatar Oct 30 '24 20:10 paulhcsun

update

✅ Branch has been successfully updated

mergify[bot] avatar Oct 30 '24 20:10 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Oct 30 '24 20:10 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0dd75ad7721af65fa106b890a18eec771af502b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Oct 30 '24 21:10 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Oct 30 '24 21:10 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Oct 30 '24 21:10 github-actions[bot]