aws-cdk fix(iam): incorrect input for AccountPrincipal is building successfully

Reason for this change

There is no validation and test that the AWS Account Id when creating AccountPrincipal Object. In my case I missed a digit when copy pasting an account id and the build still passed, the typo has been caught only during the code review process

Description of changes

Adding simple regex to check that AWS Id is 12 digits long & update error message

Description of how you validated changes

Existing tests are passing and added 2 of them

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Jun 15 '24 21:06 duranbe

Logs are quite odd

[4/4] Building fresh packages...
error /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@lerna/create/node_modules/nx, /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@nx/devkit/node_modules/nx, /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/lerna/node_modules/nx: Command failed.
Exit code: 135
Command: node ./bin/post-install
Arguments: 
Directory: /codebuild/output/src3225815236/src/github.com/aws/aws-cdk/node_modules/@lerna/create/node_modules/nx
Output:
Bus error (core dumped)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Seems issue with yarn/nx

Jun 15 '24 21:06 duranbe

This build failure can't possibly have anything to do with this change... I'll retrigger it.

Jun 21 '24 21:06 TheRealAmazonKendra

@Mergifyio update

Jun 21 '24 21:06 TheRealAmazonKendra

update

✅ Branch has been successfully updated

Jun 21 '24 21:06 mergify[bot]

For fixes, the title should describe the bug, not the solution. Could you please update it?

Jun 21 '24 21:06 TheRealAmazonKendra

Hey Kendra, thanks for the review and restarting the build

For fixes, the title should describe the bug, not the solution. Could you please update it?

Done ! Is it better with this ?

fix(iam): incorrect input for AccountPrincipal is building successfully

Jun 24 '24 15:06 duranbe

Seems this PR is breaking lots of existing test ... I'll look into it, if it's too complex or there is actual use case where the an AWS ID is not 12 digits (which should not be the case ?) I'll close it.

Jun 29 '24 10:06 duranbe

Had to refactor/fix in bunch of test files but now they use proper mock AWS Accound id 🙌

Jul 01 '24 20:07 duranbe

Bump !

Jul 09 '24 08:07 duranbe

Test updated :)

Jul 10 '24 20:07 duranbe

Good on my side :) 👍

Jul 11 '24 09:07 duranbe