aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

aws-ecs: `ContainerImage.fromEcrRepository` should be `tagOrDigest`

Open cheruvian opened this issue 1 year ago • 2 comments

Describe the issue

The underlying EcrImage constructor has the correct naming tagOrDigest since most use the helper static method the name and documentation should be updated there is as well.

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22

Links

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts#L22 https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22

cheruvian avatar Jun 06 '24 00:06 cheruvian

Yes, but I am not sure how to fix that without breaking changes. Any ideas?

pahud avatar Jun 07 '24 03:06 pahud

Looks like it's a positional argument not a named one, so shouldn't be a breaking change? (unless this is some breaking change quirk of JSII?)

cheruvian avatar Jun 27 '24 22:06 cheruvian