aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(cloudwatch): add support for labels on pie graphs (aws#28929).

Open kofrasa opened this issue 1 year ago • 2 comments

Add a new "labels" property for graph widgets to show ratios for pie graphs.

Issue #28929

Closes #28929.

Reason for this change

When using a pie graph, the percentage ratios are not shown unless the { "labels": { "visible": true } } property is enabled.

Description of changes

The commits adds a new "labels" property with the type LabelProps on the graph widget. The LabelProps type contains a single boolean key"visible" which toggles the presence of the label on a pie graph. When set to true, CloudWatch dashboard will render the percentage ratios of each segment of the pie graph. The README file has been updated to reflect the new property and how it can be used.

Description of how you validated changes

The commit includes unit, integration, and snapshot tests as would be generated by the CDK library. The change has also been manually verified from the CloudWatch console by enabling and disabling the property.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

kofrasa avatar May 21 '24 04:05 kofrasa

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Jun 28 '24 00:06 aws-cdk-automation

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 631f5f079d5e99a7f8c3f46d2c09f1661269cd2e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jul 03 '24 01:07 aws-cdk-automation

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Jul 25 '24 00:07 aws-cdk-automation

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation avatar Aug 01 '24 00:08 aws-cdk-automation

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 01 '24 00:08 github-actions[bot]