aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(ecs-patterns): dualstack ALB

Open badmintoncryer opened this issue 1 year ago • 2 comments

Issue # (if applicable)

Closes #29039.

Reason for this change

Both ApplicationLoadBalancedFargateService and ApplicationLoadBalancedEc2Service don't support specifying dualstack ALB.

Description of changes

Added ipAddressType to ApplicationLoadBalancedServiceBaseProps.

Description of how you validated changes

Added both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer avatar May 07 '24 12:05 badmintoncryer

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

aws-cdk-automation avatar May 10 '24 03:05 aws-cdk-automation

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c5477b86de00a269b9e85d339dbe5c2942574e9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar May 10 '24 03:05 aws-cdk-automation

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar May 19 '24 00:05 aws-cdk-automation

I would be interested in this change, is there anything I could help with?

jmnarloch avatar Jun 02 '24 03:06 jmnarloch

@jmnarloch Thanks for your comments. This PR waits for community review and I think it will take some weeks or months. Please wait a moment!

badmintoncryer avatar Jun 02 '24 11:06 badmintoncryer

When will this PR be approved and merged?

teankie avatar Jul 01 '24 12:07 teankie

@teankie It depends on the community reviewer and maintainer. Please 👍 to the issue to increase the priority.

badmintoncryer avatar Jul 01 '24 22:07 badmintoncryer

Hi

This PR has been pending for community review for a while. Please consider posting it on the #contributing channel in cdk.dev. Community members will be on the lookout there as well for possible reviews.

Check How to get your P2 PR community reviewed for more details.

pahud avatar Jul 30 '24 15:07 pahud

@tmokmss Thank you for your review. I'll try to create PR for those constructs later😉

badmintoncryer avatar Aug 05 '24 13:08 badmintoncryer

@pahud Hi

Thanks to my post on cdk.dev, this PR successfully passed the community review. I would appreciate it if someone could conduct a maintainer review.

Thank you in advance.

badmintoncryer avatar Aug 23 '24 11:08 badmintoncryer

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 30 '24 17:08 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 737cf8fe65856680813b566573e924672eeb55aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 30 '24 17:08 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 30 '24 17:08 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 30 '24 17:08 github-actions[bot]