aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

Published 20 hours ago • verified publisher icon aws

feat(codebuild): add missing types for webhook filters

Open msambol opened this issue 1 year ago • 5 comments

The full list is found here.

Closes #30062.

msambol avatar May 05 '24 21:05 msambol

Exemption Request: I need a GitHub access token to update the integration test: Could not find access token for server type github. I think it's OK with no integration test update as I'm only adding enum values.

msambol avatar May 06 '24 15:05 msambol

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b59148d1722e1270d77dc1a07c8546ceb5c32667
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar May 06 '24 16:05 aws-cdk-automation

Could you add an integ test for these enums? The integ tests helps prevent regressions.

See my exemption request above. I think I need an access token? Happy to, but CDK core team might need to run it?

msambol avatar May 06 '24 18:05 msambol

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

aws-cdk-automation avatar May 06 '24 18:05 aws-cdk-automation

@comcalvi The webhooks are only available on GitHub and BitBucket. I looked at doing an integration test with CodeCommit, but not possible here. Let me know how you want to proceed.

msambol avatar May 09 '24 15:05 msambol

fyi @msambol & @comcalvi: I opened https://github.com/aws/aws-cdk/pull/30204 that extends this PR and adds the requested integration test. Please have a look.

aseppala avatar May 15 '24 11:05 aseppala

If the only integration test we can add is one that can't be deployed reliably, then I think it's safe to skip the integ test for this one. Thanks both, I think we can leave the integ test off of this one.

comcalvi avatar May 20 '24 18:05 comcalvi

@comcalvi changes made as requested 👍🏼

msambol avatar May 21 '24 14:05 msambol

@comcalvi gentle nudge 😄

msambol avatar May 28 '24 19:05 msambol

@comcalvi Do I need to do something further to push this through?

msambol avatar Jun 07 '24 00:06 msambol

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Jun 11 '24 00:06 aws-cdk-automation

@comcalvi Could we push this one through before it gets closed?

msambol avatar Jun 11 '24 00:06 msambol

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f1592c5b81721db493d7dfd3011a55980301aceb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jun 11 '24 00:06 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jun 11 '24 15:06 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

aws-cdk-automation avatar Jul 25 '24 21:07 aws-cdk-automation