aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

bedrock: L2 Constructs

Open jlosito opened this issue 1 year ago • 8 comments

Describe the feature

I would like to use L2 constructs to provision Bedrock related resources with sensible defaults. Now that L1 constructs have been added via https://github.com/aws/aws-cdk/pull/29911 , this should be possible now!

Use Case

I have been using the awslabs/generative-ai-cdk-constructs library to provision and configure Bedrock related resources, but this library makes use of custom resources to perform all of its actions. I much rather use native constructs rather than custom resources.

https://github.com/awslabs/generative-ai-cdk-constructs

Proposed Solution

If possible, use the same defaults that the generative-ai-cdk-constructs library is using for each of its L2-like constructs. In my opinion, this would make it a little bit easier to users to migrate without having to change too much. If not, that's fine too.

Other Information

No response

Acknowledgements

  • [ ] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

CDK version used

2.139.0

Environment details (OS name and version, etc.)

macOS 14.4.1

jlosito avatar Apr 25 '24 15:04 jlosito

Absolutely. Please help us prioritize with 👍 .

pahud avatar Apr 25 '24 15:04 pahud

If somebody from the community wants to pick it up, that is exactly what https://www.open-constructs.org/ is for.

hoegertn avatar Apr 25 '24 17:04 hoegertn

There is a Bedrock L2 construct at awslabs/generative-ai-cdk-constructs.

badmintoncryer avatar May 12 '24 22:05 badmintoncryer

@badmintoncryer those are all using custom resources. It would be better if they were using leveraging the L1 constructs instead that were just introduced within the last month.

jlosito avatar May 12 '24 23:05 jlosito

@jlosito It's true. But a PR using L1 has been created. It seems it will be replaced soon. https://github.com/awslabs/generative-ai-cdk-constructs/pull/414

badmintoncryer avatar May 12 '24 23:05 badmintoncryer

Yes please, absolutely. Currently working with the L1s and the L2s would definitely help increase productivity.

dirkmichelmycomosi avatar May 15 '24 14:05 dirkmichelmycomosi

https://github.com/awslabs/generative-ai-cdk-constructs/pull/414 was merged today

theagenticguy avatar May 15 '24 17:05 theagenticguy

@pahud @paulhcsun we did look at the contribution guide and design guidelines to contribute to the CDK our existing L2 bedrock construct mentioned above (and maybe more). We will have some changes to do to follow the guidelines, in the meantime should we open a new GitHub issue to track this effort ? Is there anything else we should do to ? Thanks !

krokoko avatar May 29 '24 20:05 krokoko