aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

(aws-appsync): Add Enhanced Metrics configuration to CDK

Open piotrmoszkowicz opened this issue 1 year ago • 8 comments

Describe the feature

AWS AppSync some time ago introduced enhanced monitoring (https://docs.aws.amazon.com/appsync/latest/devguide/monitoring.html -> Enhanced Metrics), which allows to collect metrics at resolver/operation/data source leve. It is added within the CloudFormation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-graphqlapi.html -> EnhancedMetricsConfig), so I think it would be great feature within CDK. I will be happy to implement it, maybe even within end of the week ;)

Use Case

Ability to configure AWS AppSync with Enhanced Monitoring.

Proposed Solution

Add missing property to AppSync's L2 construct and map it properly to AWS CloudFormation.

Other Information

No response

Acknowledgements

  • [X] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

CDK version used

2.138.0

Environment details (OS name and version, etc.)

MacOS Ventura

piotrmoszkowicz avatar Apr 23 '24 11:04 piotrmoszkowicz

Hi @piotrmoszkowicz , thanks for requesting this feature and agreeing to volunteer for L2 contruct PR. It would be a helpful feature and there is already needed support by cloudformation. So please go ahead and feel free to submit the PR.

khushail avatar Apr 23 '24 17:04 khushail

Hi @khushail, done! Please take a look and help with review ;)

piotrmoszkowicz avatar Apr 23 '24 22:04 piotrmoszkowicz

Appreciate your efforts @piotrmoszkowicz . Team would be reviewing it.

khushail avatar Apr 23 '24 22:04 khushail

Hey! Can we start looking at the code review for the PR? We would like to use that one in production and it is already stable for 3 weeks.

piotrmoszkowicz avatar May 13 '24 16:05 piotrmoszkowicz

@piotrmoszkowicz , thanks for submitting the PR. I see that integ-test and snapshots needs to be added to the PR. Once those are added, a community reviewer will start the initial review followed by the maintainer review. If you need any help or guidance, please feel free to reach out on #contributing channel on cdk.dev slack.

khushail avatar May 13 '24 18:05 khushail

Can you please merge in this PR? It was automatically closed. The enhanced metrics cannot be configured via CDK, although they were released 7 months ago.

xerebz avatar Sep 02 '24 23:09 xerebz

Any update on this? Was looking to migrate an existing cloudformation template to CDK but am blocked because my appsync instance has this config and the EnhancedMetricsConfig property is not recognized

travishaby avatar Oct 16 '24 17:10 travishaby

@xerebz @travishaby , the PR can not be merged until the integration test and snapshots are provided. https://github.com/aws/aws-cdk/pull/29940 However you could seek help in cdk.dev community channel for the review and guidance on how to proceed with this PR.

khushail avatar Oct 16 '24 18:10 khushail

We would love to have this. Using App Sync in our organisation for the first time.

maherrj avatar Apr 14 '25 15:04 maherrj

I see the PR is closed. What does it mean? Will it be ever merged?

ahtokca avatar May 02 '25 12:05 ahtokca

Can this be fast tracked. please? I see only Integration tests are pending? @EdwinRad

leoujjawal avatar May 20 '25 08:05 leoujjawal