aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(events-targets): add support for AppSync as an EventBridge rule target

Open onlybakam opened this issue 11 months ago • 8 comments

Reason for this change

Introduces support to configure AppSync GraphQLAPI as an EventBridge target.

  • announcement: https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-eventbridge-appsync-target-buses/
  • documentation: https://docs.aws.amazon.com/eventbridge/latest/userguide/target-appsync.html

Description of changes

  • Expose GraphQLEndpointArn attribute in L2 GraphQLAPI construct
  • Implement events.IRuleTarget for AppSync
rule.addTarget(new targets.AppSync(api, {
  graphQLOperation: 'mutation Publish($message: String!){ publish(message: $message) { message } }',
  variables: events.RuleTargetInput.fromObject({
    message: 'hello world',
  }),
  deadLetterQueue: queue,
}));

Description of how you validated changes

unit test and integration tests

Issue

Solves #29884

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

onlybakam avatar Mar 22 '24 21:03 onlybakam

Hey @lpizzinidev & @onlybakam, thank you so much for your work on this feature. I'm new to the repo and wondering what the timeline would be to get this feature published, assuming it gets merged? Are we talking about days or weeks? :)

I have a new feature I'd like to build in my product, and this would greatly save development time. If it's coming soon, I'd rather wait until it's merged before I hand-roll a solution. 😄

djbotha avatar Apr 18 '24 06:04 djbotha

hoping to get this done soon. will address the remaining comments in the next couple of days.

onlybakam avatar Apr 18 '24 20:04 onlybakam

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 11 '24 00:05 mergify[bot]

@Mergifyio update

gracelu0 avatar May 11 '24 00:05 gracelu0

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

mergify[bot] avatar May 11 '24 00:05 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 12 '24 20:05 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 87f427d3869eabe4a51acb9cbb44b8838cbbf802
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar May 12 '24 21:05 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 12 '24 21:05 mergify[bot]

@Mergifyio queue

gracelu0 avatar May 13 '24 03:05 gracelu0

queue

🛑 The pull request has been removed from the queue default

Pull request #29584 has been dequeued. GitHub can't merge the pull request for now.. GitHub can't merge the pull request for an unknown reason. You should retry later..

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.

mergify[bot] avatar May 13 '24 03:05 mergify[bot]

@Mergifyio refresh

gracelu0 avatar May 13 '24 03:05 gracelu0

refresh

✅ Pull request refreshed

mergify[bot] avatar May 13 '24 03:05 mergify[bot]